Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMAGING-242] Upgrade to Junit5 #59

Merged
merged 3 commits into from Nov 19, 2019
Merged

[IMAGING-242] Upgrade to Junit5 #59

merged 3 commits into from Nov 19, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Nov 19, 2019

Used @mureinik 's excellent work on this PR for Commons CSV for the same end.

Only difference is that Commons Imaging uses Theories (@Theory, @Datapoint, etc). And this is not available in JUnit 4, so I used JUnit Vintage as in this post.

@kinow kinow self-assigned this Nov 19, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.762% when pulling 568d284 on kinow:junit5 into 70dd698 on apache:master.

@kinow kinow merged commit 7d8193b into apache:master Nov 19, 2019
mureinik added a commit to mureinik/commons-imaging that referenced this pull request Nov 24, 2019
Finish the work started in
apache#59 and convert the
vintage @theories to Jupiter @MethodSources.

Note that Jupiter doesn't have a built-in mechanism to create a
Cartesian product between two sources (like @theories does), so it had
to be explicitly implemented manually.
@mureinik
Copy link
Contributor

Thanks for the shout-out @kinow !

I took a look and the repository after this PR was applied, and I think it's a pretty small delta to reach a Jupiter-only project, even if it does require implementing the "logic" of a Cartesian product of arguments - see my attempt at #61

The side advantage of this is to lock down the dependencies and not allow people to mix Jupiter and Vintage in the same class as was done in TestImageReadException and TestImageWriteException (presumably by mistake?).

@kinow
Copy link
Member Author

kinow commented Nov 24, 2019

The side advantage of this is to lock down the dependencies and not allow people to mix Jupiter and Vintage in the same class as was done in TestImageReadException and TestImageWriteException (presumably by mistake?).

Mea culpa. I did 90% with IDE search-replace following the docs & looking at your CSV PR. But for Theories, Datapoints and other things that weren't in CSV I struggled a bit. Thanks for tidying it up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants