IMAGING-151: use a copy of the list, make members package-protected/private, and re-use Comparator #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a few comments too, but planning to add more later when working on IMAGING-146. |
kinow
commented
Dec 14, 2019
|
|
||
| Collections.sort(colorGroup.colorCounts, comp); | ||
| final List<ColorCount> colorCounts = colorGroup.getColorCounts(); | ||
| Collections.sort(colorCounts, new ColorCountComparator(mode)); |
There was a problem hiding this comment.
Sorting the local variable now.
| @@ -130,7 +130,7 @@ public Palette process(final BufferedImage image, final int maxColors, | |||
|
|
|||
| colorGroup.paletteIndex = i; | |||
|
|
|||
| if (colorGroup.colorCounts.size() < 1) { | |||
| if (colorGroup.getColorCounts().isEmpty()) { | |||
There was a problem hiding this comment.
There are several other places with similar code smell, will raise a PR in the next hours to use isEmpty() in the rest of the code when possible.
| @@ -52,13 +50,13 @@ public boolean performNextMedianCut(final List<ColorGroup> colorGroups, | |||
| if (ignoreAlpha && colorComponent == ColorComponent.ALPHA) { | |||
| continue; | |||
| } | |||
| Collections.sort(colorGroup.colorCounts, new ColorComparer(colorComponent)); | |||
| Collections.sort(colorCounts, new ColorCountComparator(colorComponent)); | |||
There was a problem hiding this comment.
This is sorted multiple times for each color component. Later a best color component will be chosen, and a final sort will take place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a
ComparatorforColorCount, replacing two comparators created in different parts of the code with the same logic.The list that was sorted was a member of a class that could be used elsewhere. So instead of altering the values in that list, now other classes need to access that list through a method that returns a copy of the list.
Members in the package-protected class were made package-protected (from public) or private.
Bruno