-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JCS-212 - Redundant local variable #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
}); | ||
|
||
return dsFactory; | ||
return this.dsFactories.computeIfAbsent(poolName, key -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting is all broken
@@ -646,8 +646,7 @@ protected void processUpdate(final ICacheElement<K, V> ce) | |||
|
|||
try | |||
{ | |||
final ICacheElement<K, V> readObject = dataFile.readObject(ded); | |||
object = readObject; | |||
object = dataFile.readObject(ded); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge master as I just fixed this myself.
|
||
return pool; | ||
return pools.computeIfAbsent(name, key -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check indentation.
|
||
return pool; | ||
return schedulerPools.computeIfAbsent(name, key -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check indentation.
HI @tvand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Inline unnecessary local variables, which add nothing to the comprehensibility of a method