Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LANG-1300: Convert CharSequence to String for int-methods in StringUtils #250

Closed
wants to merge 4 commits into from
Closed

LANG-1300: Convert CharSequence to String for int-methods in StringUtils #250

wants to merge 4 commits into from

Conversation

MarkDacek
Copy link
Contributor

@MarkDacek MarkDacek commented Mar 4, 2017 •
edited
Loading

@chtompki
Copy link
Member

chtompki commented Mar 4, 2017

I'll give this a look this evening.

@MarkDacek
Copy link
Contributor Author

If this is too simplistic of a change, consider the minor change I did here. I based it off of the JDK implementation that handles supplementary characters.

MarkDacek@cde4c52

@MarkDacek MarkDacek closed this Mar 5, 2017
@coveralls
Copy link

coveralls commented Mar 5, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 94.455% when pulling cc70a8a on MarkDacek:LANG-1300 into 6597c19 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 94.484% when pulling cc70a8a on MarkDacek:LANG-1300 into 6597c19 on apache:master.

@coveralls
Copy link

coveralls commented Mar 5, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 94.448% when pulling cc70a8a on MarkDacek:LANG-1300 into 6597c19 on apache:master.

MarkDacek added a commit to MarkDacek/commons-lang that referenced this pull request Mar 6, 2017
@MarkDacek
This closes apache#250
3072c65
@MarkDacek MarkDacek deleted the LANG-1300 branch March 6, 2017 01:50
@chtompki chtompki mentioned this pull request Mar 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDacek @chtompki @coveralls