Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANG-1478 class name abbreviation fix #445

Closed
wants to merge 1 commit into from
Closed

LANG-1478 class name abbreviation fix #445

wants to merge 1 commit into from

Conversation

verhas
Copy link
Contributor

@verhas verhas commented Aug 22, 2019

Fix ClassUtils class name abbreviation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.336% when pulling ab80375 on verhas:LANG-1478 into 2f38c4b on apache:master.

Copy link
Contributor

@Stzx Stzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should add javaDoc at the same time, add a new example.

<tr><td>"java.lang.String"</td><td>16</td><td>"java.lang.String"</td></tr>

@kinow kinow changed the title LAN-1478 class name abbreviation fix LANG-1478 class name abbreviation fix Aug 24, 2019
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Javadocs to include an example of a call with a class name, and len with the exact class name length, and its expected output, please?

@kinow
Copy link
Member

kinow commented Aug 24, 2019

@Stzx

I think I should add javaDoc at the same time, add a new example.

+1, added a review comment for @verhas . And @verhas , thanks a lot for your contributions, we should be able to merge them soon (unless we need to wait for a major release, then I will update JIRA issues accordingly)

@kinow
Copy link
Member

kinow commented Aug 25, 2019

@verhas I think this and #446 are good to be included in the next release. Just need you to address the review feedback and update both branches. If you could rebase it onto master as well, please. I've just fixed the Checkstyle issues, and Travis build should pass for both 👍

Thanks
Bruno

@verhas
Copy link
Contributor Author

verhas commented Oct 14, 2019

This request became outdated as the method to be fixed was refactored 100%.

@verhas verhas closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants