LANG-1647 - Check if an throwable is a checked exception #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherbert
reviewed
Mar 5, 2021
src/changes/changes.xml
Outdated
| @@ -100,6 +100,7 @@ The <action> type attribute can be add,update,fix,remove. | |||
| <action type="add" dev="jochen">Introduce the use of @Nonnull, and @Nullable, and the Objects class as a helper tool.</action> | |||
| <action type="add" dev="ggregory" due-to="Arturo Bernal, Gary Gregory">Add and use true and false String constants #714.</action> | |||
| <action type="add" dev="ggregory" due-to="Arturo Bernal, Gary Gregory">Add and use ObjectUtils.requireNonEmpty() #716.</action> | |||
| <action issue="LANG-1647" type="add" dev="abernal" due-to="">Check if an throwable is a checked exception.</action> | |||
There was a problem hiding this comment.
This is in the wrong place
There was a problem hiding this comment.
true. thanks. @aherbert
garydgregory
reviewed
Mar 5, 2021
| * @see java.lang.Error | ||
| * @since 3.12.1 | ||
| */ | ||
| public static boolean isCheckedException(final Throwable throwable) { |
There was a problem hiding this comment.
The API name is misleading since it takes more than Exception as input.
Going further, I think the type name in the method name is redundant and calling the API 'isChecked' should be enough.
garydgregory
reviewed
Mar 5, 2021
| * @see java.lang.Exception | ||
| * @see java.lang.RuntimeException | ||
| * @see java.lang.Error | ||
| * @since 3.12.1 |
There was a problem hiding this comment.
Adding a new API is not a maintenance version change per semantic versioning guidelines, the version should be the next minor one.
There was a problem hiding this comment.
Hi @garydgregory
Changed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea it's have a function that check if a given throwable is a checked exception. There are some similar function in ConcurrentUtils, but have package visibility and return the same exception.
Seem logic have this verification in the class that have this responsibility -
ExceptionUtils