Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage of ComparableUtils from 71% to 100% #898

Merged

Conversation

stevebosman-oc
Copy link
Contributor

Static methods in ComparableUtils had 0 coverage this fixes that

Contributed on behalf of the @opencastsoftware open source team

@garydgregory
Copy link
Member

Hi @stevebosman-oc
Thank you for your PR. Please rebase on git master so we can see the newly committed coverage.yml in action :-)

@codecov-commenter
Copy link

Codecov Report

Merging #898 (a71c794) into master (3a0ba3c) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #898      +/-   ##
============================================
+ Coverage     91.25%   91.30%   +0.04%     
- Complexity     7379     7386       +7     
============================================
  Files           188      188              
  Lines         15966    15966              
  Branches       2998     2998              
============================================
+ Hits          14570    14577       +7     
+ Misses          788      782       -6     
+ Partials        608      607       -1     
Impacted Files Coverage Δ
...va/org/apache/commons/lang3/CharSequenceUtils.java 88.80% <0.00%> (+0.79%) ⬆️
.../apache/commons/lang3/compare/ComparableUtils.java 100.00% <0.00%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0ba3c...a71c794. Read the comment docs.

@stevebosman-oc stevebosman-oc force-pushed the feature/ComparableUtilsCoverage branch from a71c794 to 6daba52 Compare May 26, 2022 13:26
@stevebosman-oc
Copy link
Contributor Author

I don't know how CharSequenceUtils coverage would have been affected. but the changes to ComparableUtils are pretty much what I expected

@garydgregory garydgregory merged commit f7c338b into apache:master May 26, 2022
stevebosman-oc added a commit to stevebosman-oc/commons-lang that referenced this pull request May 26, 2022
stevebosman-oc pushed a commit to stevebosman-oc/commons-lang that referenced this pull request May 26, 2022
@stevebosman-oc stevebosman-oc deleted the feature/ComparableUtilsCoverage branch May 27, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants