[numbers] support JUnit 5 tests

[grimreaper]

No description provided.

[aherbert]

I think the recommended way is to use the JUnit Bill of Materials which contains all the versions which work together:

  <dependencyManagement>
      <dependency>
        <groupId>org.junit</groupId>
        <artifactId>junit-bom</artifactId>
        <!-- define this in properties -->
        <version>${numbers.junit.bom.version}</version>
        <scope>import</scope>
        <type>pom</type>
      </dependency>
    </dependencies>
  </dependencyManagement>

  <!-- Include what you require without version numbers. 
       They are all in the BOM. -->
  <dependencies>
    <dependency>
      <groupId>org.junit.jupiter</groupId>
      <artifactId>junit-jupiter</artifactId>
      <scope>test</scope>
    </dependency>
    <!-- For IDE support --> 
    <dependency>
      <groupId>org.junit.platform</groupId>
      <artifactId>junit-platform-launcher</artifactId>
      <scope>test</scope>
    </dependency>
    <!-- For JUnit 4 support --> 
    <dependency>
      <groupId>org.junit.platform</groupId>
      <artifactId>junit-platform-runner</artifactId>
      <scope>test</scope>
    </dependency>
    <dependency>
      <groupId>org.junit.vintage</groupId>
      <artifactId>junit-vintage-engine</artifactId>
      <scope>test</scope>
    </dependency>
  </dependencies>

You can see what it bundles on Maven repository org.junit:junit-bom:5.4.2.

I am not sure how it works with the legacy junit 4 dependency. I would try deleting that from the POM and just trying with the vintage engine dependency.

[coveralls]

Coverage remained the same at 93.642% when pulling fccc6fe on grimreaper:eax/junit5-support into d01c9e7 on apache:master.

[grimreaper]

@aherbert what about this iteration? As I wrote in my original email, I don't know maven that well.

(also, you're allowed to push to this branch if it'd help)

[aherbert]

Looks fine. Let's see if Travis can run all the tests.

[grimreaper]

Updated. Travis failed previously on coveralls related errors but not on the core tests.

[aherbert]

All looks good now

[grimreaper]

Pushed as fccc6fe. Hope I did that right.

[aherbert]

I've pulled master and the changes are there. Downstream PRs for the switch to JUnit 5 should all be OK.

[grimreaper]

actually see 6bcc6d9