RNG-71: Validate parameters for the distribution samplers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds checks matching those found in the commons-math3 distributions to the samplers. The existing validation checks in the PoissonSampler have had their exception messages changed for consistency. A test for the ContinuousUniformSampler was added to demonstrate no range checks are required.
asfgit
pushed a commit
that referenced
this pull request
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks matching those found in the commons-math3 distributions
to the samplers. An additional check missing in commons-math3 was added to the
LogNormalSamplerto ensure the mean (scale) parameter was positive. I am unsure why this check is missing in CM as it is defined here Log-normal_distribution.The existing validation checks in the PoissonSampler
have had their exception messages changed for consistency across all the samplers.
A test for
the ContinuousUniformSampler was added to demonstrate no range checks
are required.