VFS-783: Proper http scheme setting on webdav/webdav2 with unit tests #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
pushed a commit
that referenced
this pull request
Oct 31, 2020
#143. As of git master today, #143 does not prove anything has been fixed: - Add ONLY `org.apache.commons.vfs2.provider.webdav4.Webdav4FileObject.getInternalURI()` - Add `Webdav4FileObjectTest`. run it, and it passes. Therefore, I've only committed these changes but with changes to `Webdav4FileObjectTest` to add try-with-resources blocks.
|
Hi @woonsan
May you please update to git master and see if you can update the test or provide a new one? |
|
Hi @garydgregory , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to add unit tests for the @satish-csi 's pull request: #118.
I have cherry-picked @satish-csi 's commits in the feature branch and added a unit test class for the fix.
Please review and merge it if okay. Thanks!