Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: upgrade Google Services Gradle Plugin google-services@4.3.5" #1191

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 31, 2021

Reverts #1177

Sorry, it seems some people do not trust that this follows semver and feels it may not fit a minor release.
We will revert this PR and would like it resubmitted for the major release.

@codecov-io
Copy link

codecov-io commented Mar 31, 2021

Codecov Report

Merging #1191 (5638f27) into master (1f5426f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files          22       22           
  Lines        1772     1772           
=======================================
  Hits         1300     1300           
  Misses        472      472           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5426f...5638f27. Read the comment docs.

@erisu erisu merged commit 690ff3f into master Apr 8, 2021
@erisu erisu deleted the revert-1177-patch-4 branch April 8, 2021 05:04
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants