-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(AndroidManifest): update theme to Theme.AppCompat.NoActionBar #1207
Conversation
spec/unit/AndroidManifest.spec.js
Outdated
@@ -40,7 +40,7 @@ describe('AndroidManifest', () => { | |||
android:supportsRtl="true" android:debuggable="true"> | |||
<activity android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale" | |||
android:label="@string/activity_name" android:launchMode="${ACTIVITY_LAUNCH_MODE}" | |||
android:name="${ACTIVITY_NAME}" android:theme="@android:style/Theme.DeviceDefault.NoActionBar" | |||
android:name="${ACTIVITY_NAME}" android:theme="@android:style/Theme.AppCompat.NoActionBar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The android:
before style/Theme was also removed
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 21 21
Lines 1692 1692
=======================================
Hits 1218 1218
Misses 474 474 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Motivation and Context
Update
AndroidManifest.spec.js
based on comment from this PR: #1052 (review)Description
Changed
Theme.DeviceDefault.NoActionBar
toTheme.AppCompat.NoActionBar
to match changes from PR #1052