Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(check_reqs): drop originalError param from check_android_target #1260

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

raphinesse
Copy link
Contributor

This refactor removes a strange optional parameter from check_reqs.check_android_target in favor of having the sole user of that parameter handle the related logic itself.

@raphinesse raphinesse added this to the 9.1.1 milestone Jul 6, 2021
@raphinesse raphinesse requested review from erisu and breautek July 6, 2021 10:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1260 (09e3aae) into master (334d02d) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage   71.08%   71.06%   -0.02%     
==========================================
  Files          22       22              
  Lines        1705     1704       -1     
==========================================
- Hits         1212     1211       -1     
  Misses        493      493              
Impacted Files Coverage Δ
...n/templates/cordova/lib/builders/ProjectBuilder.js 73.54% <85.71%> (-0.31%) ⬇️
bin/templates/cordova/lib/check_reqs.js 71.42% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334d02d...09e3aae. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphinesse raphinesse merged commit 6f35d0b into apache:master Jul 6, 2021
@raphinesse raphinesse deleted the drop-originalError-param branch July 6, 2021 11:33
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants