Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rebuild package-lock w/ lint corrections #1649

Merged
merged 2 commits into from Aug 23, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Aug 23, 2023

Platforms affected

n/a

Motivation and Context

  • Remove audit warnings
  • Latest sub-dependencies for development testing

Description

  • Rebuilt package-lock.json
  • Apply lint fix. Remove file starting new line.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #1649 (f0f4e5d) into master (c9e7c59) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1649   +/-   ##
=======================================
  Coverage   72.35%   72.35%           
=======================================
  Files          23       23           
  Lines        1834     1834           
=======================================
  Hits         1327     1327           
  Misses        507      507           
Files Changed Coverage Δ
lib/config/CordovaGradleConfigParserFactory.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good for patch

@erisu erisu merged commit a7cd422 into apache:master Aug 23, 2023
9 checks passed
@erisu erisu deleted the chore/rebuild-package-lock branch August 23, 2023 09:24
breautek pushed a commit to breautek/cordova-android that referenced this pull request Oct 21, 2023
* chore: rebuild package-lock.json
* chore: remew file starting new-line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants