Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-10894 Add supports-screens config from the config.xml file #280

Closed
wants to merge 1 commit into from

Conversation

akofman
Copy link

@akofman akofman commented Mar 17, 2016

Just added the availability to update the supports-screens element of the AndroidManifest.xml file from the config.xml file.

@infil00p
Copy link
Member

This LGTM, but I'm going to need an ICLA assuming you don't already have one.
http://www.apache.org/licenses/#clas

@akofman
Copy link
Author

akofman commented Mar 17, 2016

I already have one, do you want me to send it to you by e-mail ?

@shazron
Copy link
Member

shazron commented Mar 17, 2016

CLA verified for Alexis Kofman: http://people.apache.org/unlistedclas.html

@infil00p
Copy link
Member

infil00p commented Sep 9, 2016

I'm going to close this PR with an empty commit. The config-changes code added recently makes this change no longer needed, since you can just do this:

<edit-config file="AndroidManifest.xml" target="/manifest" mode="merge"> <supports-screens android:resizeable=["true"| "false"] android:smallScreens=["true" | "false"] android:normalScreens=["true" | "false"] android:largeScreens=["true" | "false"] android:xlargeScreens=["true" | "false"] android:anyDensity=["true" | "false"] android:requiresSmallestWidthDp="integer" android:compatibleWidthLimitDp="integer" android:largestWidthLimitDp="integer"/> </edit-config>

@asfgit asfgit closed this in d2a159d Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants