Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14127: (android) Move google maven repo ahead of jcenter #450

Merged
merged 1 commit into from Jun 12, 2018

Conversation

jcesarmobile
Copy link
Member

Platforms affected

Android

What does this PR do?

Move google maven repo ahead of jcenter because of some problem to get Google libs from jcenter

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #450 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   44.16%   44.16%           
=======================================
  Files          17       17           
  Lines        1698     1698           
  Branches      314      314           
=======================================
  Hits          750      750           
  Misses        948      948

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ee925...38d0e68. Read the comment docs.

@jcesarmobile jcesarmobile merged commit 3df8f8b into apache:master Jun 12, 2018
@jcesarmobile jcesarmobile deleted the CB-14127 branch June 12, 2018 09:46
@josenobile
Copy link

When this commit already merged in the master branch can be merged into a release? 7.1.1 or 7.2.0 ?

@jcesarmobile
Copy link
Member Author

Current master is 7.2.0-dev, so this should be on next 7.2.0 release

@garyjohnson
Copy link

Seeing this issue in 6.4.0 -- are all versions of cordova-android broken due to this? Will they be patched? Is there a version I can upgrade to now without installing the plugin from git?

@jcesarmobile
Copy link
Member Author

Only security fixes are back ported to previous versions, and only for 6 months since latest major version bump, so 6.4.0 won't get this because it's not security related.

This is not released yet, so you have to install from git, or probably using @nightly as version (didn't try, might also need nightly CLI).

You can also manually move it up in your project as workaround

@garyjohnson
Copy link

Understandable, but aren't all released versions of cordova-android currently broken because of this? Or does this only affect a subset of projects somehow?

@jcesarmobile
Copy link
Member Author

It doesn't directly affect cordova-android, it affects some plugins that can't fetch the dependencies because Google didn't publish their libraries correctly in jcenter. This fix is more a workaround than a real fix, the real fix is that Google republish the libraries again and do it right.

And even if it affected all cordova-android versions and all Cordova apps, we only backport security fixes.

@davidsidlinger
Copy link

After this change, we're still getting the "old" repository order in platforms/android/CordovaLib/build.gradle, though the build.gradle in platforms/android/ is 👌.

@dpogue
Copy link
Member

dpogue commented Oct 23, 2018

@davidsidlinger That was just fixed in #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants