Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always put the Google repo above jcenter #523

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Always put the Google repo above jcenter #523

merged 1 commit into from
Oct 23, 2018

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 23, 2018

Platforms affected

Android

What does this PR do?

Resolves #521

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

jcesarmobile
jcesarmobile approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should probably also cherry-pick to 7.1.x branch and do the 7.1.2 release with this fix and some other already cherry-picked commits.

@dpogue dpogue merged commit 03c62e1 into apache:master Oct 23, 2018
@dpogue dpogue deleted the gradle-repo-order branch October 23, 2018 17:34
@dpogue dpogue mentioned this pull request Oct 23, 2018
Merged
3 tasks
@ippeiukai ippeiukai mentioned this pull request Oct 24, 2018
Closed
3 tasks
This was referenced Oct 24, 2018
Merged
Closed
Closed
This was referenced Oct 25, 2018
Closed
Closed
Closed
@millerf
Copy link

millerf commented Oct 26, 2018

Can we get a minor release with this? We have a broken build that requires modifying this manually.

Same thing here!

@jeffersoncardoso
Copy link

jeffersoncardoso commented Oct 30, 2018 •
edited
Loading

Can we get a minor release with this? We have a broken build that requires modifying this manually.

Same

@jkasten2 jkasten2 mentioned this pull request Nov 1, 2018
Closed
@Jule-
Copy link
Contributor

Jule- commented Nov 5, 2018

We'll make a patch release 7.1.2 whenever someone has time to start the process and submit it to the list for voting.

@dpogue any news?

@dpogue
Copy link
Member Author

dpogue commented Nov 7, 2018

Cordova-Android 7.1.2 is published, blog post should be up shortly

@Jule-
Copy link
Contributor

Jule- commented Nov 8, 2018

@dpogue Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dpogue @millerf @jeffersoncardoso @Jule- @amreladawy @jcesarmobile