Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve test readme #582

Merged
merged 1 commit into from
Dec 4, 2018
Merged

improve test readme #582

merged 1 commit into from
Dec 4, 2018

Conversation

janpio
Copy link
Member

@janpio janpio commented Nov 23, 2018

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@brodycj
Copy link
Contributor

brodycj commented Nov 23, 2018

I wonder if we should add a pointer to apache/cordova#54?

@janpio
Copy link
Member Author

janpio commented Nov 23, 2018

Already done in apache/cordova#54 (comment)

@brodycj
Copy link
Contributor

brodycj commented Dec 4, 2018

@janpio should we merge this?

@janpio janpio merged commit 5f44af3 into master Dec 4, 2018
@janpio janpio deleted the janpio-patch-1 branch December 4, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brodycj brodycj brodycj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janpio @brodycj