Do not clobber process properties with test mocks #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
I left a suggestion as I didn’t quite get it at first that spyOn would stop the actual function from being executed by default (unless .and.callThrough() is chained on). I think it would be nice to add a comment to make this clear for the sake of others. Otherwise, the change looks perfect to me.
@raphinesse please feel free to edit or delete my suggested comment when merging.
5 tasks
raphinesse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the last section Dot notation in the
rewiredocs, the code from #774 permanently clobbers various properties on theprocessglobal. This PR fixes #768 without permanently alteringprocess.CC @breautek