Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace superspawn & child_process with execa #862

Merged
merged 13 commits into from
Jan 6, 2020

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Nov 3, 2019

Motivation and Context

apache/cordova#16

Includes commit from #860 (will rebase ASAP). Depends on #832 and #861.

Description

Replace superspawn & child_process usage with execa.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@raphinesse raphinesse added this to the 8.0.1 milestone Nov 3, 2019
@raphinesse raphinesse modified the milestones: 8.0.1, 9.0.0 Nov 3, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes expected to remain here or should be moved to the Dropping Q PR? These changes kinda blend together and could be done in either PR I am guessing.

bin/templates/cordova/lib/log.js Show resolved Hide resolved
spec/unit/builders/ProjectBuilder.spec.js Show resolved Hide resolved
bin/templates/cordova/lib/check_reqs.js Show resolved Hide resolved
bin/templates/cordova/lib/log.js Show resolved Hide resolved
spec/unit/builders/ProjectBuilder.spec.js Show resolved Hide resolved
spec/unit/builders/ProjectBuilder.spec.js Show resolved Hide resolved
spec/unit/builders/ProjectBuilder.spec.js Show resolved Hide resolved
@erisu
Copy link
Member

erisu commented Jan 6, 2020

As #860 has been merged, I went ahead and rebased the branch with latest master.

@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #862 into master will decrease coverage by 0.09%.
The diff coverage is 67.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #862     +/-   ##
=========================================
- Coverage   66.46%   66.37%   -0.1%     
=========================================
  Files          19       19             
  Lines        1855     1847      -8     
=========================================
- Hits         1233     1226      -7     
+ Misses        622      621      -1
Impacted Files Coverage Δ
bin/templates/cordova/lib/device.js 100% <100%> (ø) ⬆️
bin/templates/cordova/lib/android_sdk.js 100% <100%> (ø) ⬆️
...n/templates/cordova/lib/builders/ProjectBuilder.js 67.42% <100%> (-0.37%) ⬇️
bin/templates/cordova/lib/Adb.js 100% <100%> (ø) ⬆️
bin/templates/cordova/lib/check_reqs.js 49.49% <16.66%> (-0.01%) ⬇️
bin/templates/cordova/lib/build.js 30.55% <33.33%> (ø) ⬆️
bin/templates/cordova/lib/emulator.js 89.45% <58.82%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3cc75c...3a9d2a2. Read the comment docs.

@erisu erisu added this to Reviewer approved in Release Plan - 9.1.0 Jan 6, 2020
@raphinesse raphinesse merged commit fd57909 into apache:master Jan 6, 2020
Release Plan - 9.1.0 automation moved this from Reviewer approved to Done Jan 6, 2020
@raphinesse raphinesse deleted the execa branch January 7, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants