New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of cordova-common/superspawn #16
Comments
I think we want to replace |
Whatever works, I was getting this from apache/cordova-common#50 but |
To provide more context: So yes, we want something a bit more high-level than |
@brodybits That is what I'm suggesting. Or I don't understand the question. |
I am getting a bit confused here. #16 (comment) and #16 (comment) indicate to me that we should skip I would personally favor the two-step process:
@raphinesse can you please straighten me out here? I would also like to motion that we hide or remove the following comments as "off-topic": |
@brodybits Now I understand. Yes, I would favor a two step process too since migration to I hid the comments you referred to as "resolved" |
apache/cordova-common#50 is one PR, doing one thing. These are not related only in that this issue only makes sense after apache/cordova-common#50 has been merged to remove the Windows specific handling. |
Thanks Raphael for the perfect disposition. Thanks Janpio for the
clarification. I would like to make another motion to put execa into the
title and description of either this issue or a new issue.
|
This goal of this issue is to "Remove usage of cordova-common/superspawn". |
Another rationale I gave in #7 (comment) is that |
I'd like to finally resolve this issue and #7, so I'm going to try and finish the transformation we started here. |
After apache/cordova-common#50 is merged,
superspawn
is just a small wrapper aroundcross-spawn
, that makes sure thecmd
is actually executable by chmod-ing the file. As this should never be necessary for e.g.npm
and other commands we run, this is probably only appropriate in places like hooks or similar.superspawn
can thus be replaced with direct invocations ofcross-spawn
, maybe removed alltogether.The text was updated successfully, but these errors were encountered: