Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove legacy/build.gradle from template #989

Merged

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jun 8, 2020

Platforms affected

Android

Motivation and Context

While looking into Gradle files to be updated & tested in PR #988, I discovered bin/templates/project/legacy/build.gradle which seems to be outdated and no longer needed.

Description

remove bin/templates/project/legacy/build.gradle

Testing

  • tested this update with the spec test app in cordova-sqlite-storage

Checklist

  • I've run the tests to see all new and existing tests pass - verified green CI build
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #989   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          21       21           
  Lines        1866     1866           
=======================================
  Hits         1271     1271           
  Misses        595      595           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a830145...8224694. Read the comment docs.

@brodycj brodycj marked this pull request as ready for review June 8, 2020 01:52
@brodycj brodycj added this to the 9.0.0 milestone Jun 8, 2020
@brodycj brodycj merged commit 2a61b75 into apache:master Jun 8, 2020
@brodycj brodycj deleted the remove-legacy-build-gradle-from-template branch June 8, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants