Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12901 Cli Refactor #283

Closed

Conversation

purplecabbage
Copy link
Contributor

What does this PR do?

  • fixed failing tests.
  • adjusted tests to call cordova instead of cordova.raw
  • added tests to compare cordova.raw and cordova
  • changed some console.log to logger.log
  • help module returns help text and does not print it
    -- this is to make testing easier and not have it spit all over jasmine output.
  • various minor refactors, removed some un-needed promises etc.
  • added timeoutInSecs property to make user prompts testable without waiting for 30 seconds
  • this includes @stevengill 's previous pr

Platforms affected

tooling

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

stevengill and others added 5 commits June 16, 2017 14:37
… compare cordova.raw and cordova, changed some console.log to logger.log; help module returns help text and does not print it, this is to make testing easier and not have it spit all over jasmine output. various minor refactors, removed some un-needed promises
@alsorokin
Copy link
Contributor

Without these changes cordova create foo would give us Error: cordova.raw.create is not a function, right?
Or is it my local linking issue?

@purplecabbage
Copy link
Contributor Author

That is correct!
The cordova-lib changes are already on master, so together they are broken without these changes.

@alsorokin
Copy link
Contributor

@purplecabbage great, thanks for the clarification

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

images

@asfgit asfgit closed this in 8f0cc6f Jun 20, 2017
alexblom pushed a commit to isleofcode/corber that referenced this pull request Oct 16, 2017
I needed to make this change to get `corber init` to work for me. It might have something to do with this: apache/cordova-cli#283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants