CB-13772: print version numbers correctly in "cordova requirements" #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where "cordova requirements" printed out [object Object] in place of the version number.
|
Hey @darcymeyer, this looks like a useful change - I also noticed this happening. Do you know why this suddenly is a problem? |
|
Hi @janpio, I have no idea when or why this bug was introduced, I just noticed it one day. Maybe someone changed the json structure in which the version information was returned and didn't update the cli? |
|
Ok, thanks for the update. I am a bit careful merging this, as I am not 100% sure this is not somehow environment dependant or something :/ Anyone have any more insight here? |
janpio
approved these changes
Aug 10, 2018
|
After looking at the code again, I am pretty confident this won't break anything. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the bug where
cordova requirementsdid not print out version numbers correctly.Previously, it would print something like
ios-deploy: installed [object Object]. Now it printsios-deploy: installed 1.9.2.What testing has been done on this change?
This was a one line fix so none of the automated testing was run. I manually verified that the fix prints the version numbers correctly for the Android and iOS requirements.
Checklist
Issue reported here: https://issues.apache.org/jira/browse/CB-13772
(No additional testing applicable)