Fix spec label for build tests #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
janpio
reviewed
Nov 26, 2018
| @@ -72,7 +72,7 @@ describe('cordova cli', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Test#004 : project commands other than plugin and platform', () => { | |||
There was a problem hiding this comment.
where did this "Test#004 : project commands other than plugin and platform" go then? was this always a faulty description making no sense?
There was a problem hiding this comment.
The description "project commands other than plugin and platform", with no test number, was introduced in c775d2a back in 2013. Back then the description was strictly correct but not the most helpful since the only project command tested in that section was "build". No longer correct as of 8956c75 where tests of "config" were introduced.
Test numbering was introduced in 2652919, where the described block starting here was mistakenly given a test number.
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Dec 4, 2018
janpio
approved these changes
Dec 4, 2018
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.