Add unit tests for the telemetry module

[raphinesse]

Motivation and Context

The telemetry module had bad test coverage and I was about to start working on some improvements in that area. So I decided to first write some decent tests for it.

Description

It might seem odd that I also tested some aspects of our dependency insight, but in some cases it was not at all clear what exactly would be happening. So I decided to just add some tests for interesting cases.

[breautek]

+1 but I think a ticket should be raised for filters falsy and empty arguments [T010] fix if there is no ticket already.

[erisu]

👍

[erisu]

I just noticed that two of the AppVeyor tests failed. It seems those two tests are in the describe block that uses the new mock-stdin package. I wonder if Windows is supported though the packages README does mention anything about OS requirements.

[raphinesse]

+1 but I think a ticket should be raised for filters falsy and empty arguments [T010] fix if there is no ticket already.

Actually I already have a fix for that on my machine. I just wanted to get the unit tests merged first. So I will be posting a PR for that shortly.

[raphinesse]

I just noticed that two of the AppVeyor tests failed. It seems those two tests are in the describe block that uses the new mock-stdin package. I wonder if Windows is supported though the packages README does mention anything about OS requirements.

Haha, that was my first guess too. But it turned out that insight never shows prompts if process.stdout.isTTY is false. Which is the case on AppVeyor.

[codecov-io]

Codecov Report

Merging #471 into master will increase coverage by 3.9%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #471     +/-   ##
=========================================
+ Coverage   79.68%   83.59%   +3.9%     
=========================================
  Files           3        3             
  Lines         256      256             
=========================================
+ Hits          204      214     +10     
+ Misses         52       42     -10

Impacted Files	Coverage Δ
src/telemetry.js	96.55% <0%> (+34.48%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed1d5e...5151470. Read the comment docs.