Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Updated cordova-common and cordova-lib for the new framework link attribute. #584

Closed

Conversation

TylerBreau
Copy link

@TylerBreau TylerBreau commented Oct 13, 2022

Platforms affected

iOS

Motivation and Context

This PR depends on 2 other PRs:
apache/cordova-common#179
apache/cordova-lib#898

This PR is to update cordova-cli for the new link attribute being introduced in cordova-common.

This PR is directly related to apache/cordova-ios#1266
This PR provides support for reading the link attribute from framework tags.
The cordova-ios PR updates the iOS platform to use the new link attribute when adding frameworks.

cordova-docs pr: apache/cordova-docs#1267

Description

Updated cordova-common to apache/cordova-common#179.
Update cordova-lib to apache/cordova-lib#898.

Testing

I've ran npm test.

Tested various combinations of framework tag's embed and link attributes by installing a plugin using these attributes. I would observe how the XCFramework is added to the the XCode project with the following focuses:
-Is the XCFramework embedded (or not embedded) in Build Phrases?
-Is the XCFramework linked (or not linked) in Build Phrases?
-Is the XCFramework set to "Embed and Sign" in General?

I have ran my company's app using these changes.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek changed the title Updated cordova-common and cordova-lib for the new framework link attribute. WIP: Updated cordova-common and cordova-lib for the new framework link attribute. Oct 13, 2022
@dpogue
Copy link
Member

dpogue commented Oct 19, 2022

Going to close this because we definitely don't want to do updates by including tar.gz files committed to the repo.

@dpogue dpogue closed this Oct 19, 2022
@TylerBreau
Copy link
Author

Going to close this because we definitely don't want to do updates by including tar.gz files committed to the repo.

Yes, the plan was to remove the tgz files once common and lib had releases were realized. This is why the PR is still in a draft mode.

WIth that said, the link attribute PRs for cordova-common, cordova-lib, and cordova-cli should be closed in favour of apache/cordova-common#181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants