Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Updated cordova-common for the new framework link attribute. #898

Closed

Conversation

TylerBreau
Copy link
Contributor

@TylerBreau TylerBreau commented Oct 13, 2022

Platforms affected

iOS

Motivation and Context

This PR depends on apache/cordova-common#179.
This PR is to update the cordova-common package after apache/cordova-common#179 is merged in.

This PR is required to update cordova-cli so that these changes can actually be used.

cordova-docs pr: apache/cordova-docs#1267

Description

Updated cordova-common to apache/cordova-common#179.

Testing

I've ran npm test.

Tested various combinations of framework tag's embed and link attributes by installing a plugin using these attributes. I would observe how the XCFramework is added to the the XCode project with the following focuses:
-Is the XCFramework embedded (or not embedded) in Build Phrases?
-Is the XCFramework linked (or not linked) in Build Phrases?
-Is the XCFramework set to "Embed and Sign" in General?

I have ran my company's app using these changes.

I found 1 test failing in cordova-lib master. Naturally, since it failed on master and was not related to my changes, it was also failing on my branch.

pkgJson platform end-to-end with --save Test#012 : platform with local path is added correctly with --save
 - Unhandled promise rejection: TypeError: message.split is not a function
   at <Jasmine>
 - Error: Timeout - Async function did not complete within 150000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)
   at <Jasmine>
   at listOnTimeout (node:internal/timers:559:17)
   at processTimers (node:internal/timers:502:7)

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek changed the title Updated cordova-common for the new framework link attribute. WIP: Updated cordova-common for the new framework link attribute. Oct 13, 2022
@dpogue
Copy link
Member

dpogue commented Oct 19, 2022

Going to close this because we definitely don't want to do updates by including tar.gz files committed to the repo.

@dpogue dpogue closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants