WIP: Updated cordova-common for the new framework link attribute. #898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
This PR depends on apache/cordova-common#179.
This PR is to update the cordova-common package after apache/cordova-common#179 is merged in.
This PR is required to update cordova-cli so that these changes can actually be used.
cordova-docs pr: apache/cordova-docs#1267
Description
Updated cordova-common to apache/cordova-common#179.
Testing
I've ran npm test.
Tested various combinations of framework tag's embed and link attributes by installing a plugin using these attributes. I would observe how the XCFramework is added to the the XCode project with the following focuses:
-Is the XCFramework embedded (or not embedded) in Build Phrases?
-Is the XCFramework linked (or not linked) in Build Phrases?
-Is the XCFramework set to "Embed and Sign" in General?
I have ran my company's app using these changes.
I found 1 test failing in cordova-lib master. Naturally, since it failed on master and was not related to my changes, it was also failing on my branch.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)