Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
CB-13496: Fix greedy regex in plist-helpers #45
What does this PR do?
Resolves an issue where a regex was overly greedy when comparing plist entries for merging and could result in collapsing several of them into a single entry.
What testing has been done on this change?
Added a test that fails with current master and passes with this change, based on the details provided by @knight9999 in the JIRA bug. It sounds like this might be the cause of GH-44 as well (/fyi @donnie-jp).
Now, my fix assumes that we're always looking for
@@ Coverage Diff @@ ## master #45 +/- ## ======================================= Coverage 86.24% 86.24% ======================================= Files 19 19 Lines 1730 1730 Branches 360 360 ======================================= Hits 1492 1492 Misses 238 238
left a comment
This looks good.