Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(windows) Add .jsproj as file extension for XML files to ConfigFile #78

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

holyhoehle
Copy link
Contributor

Platforms affected

Windows

Motivation and Context

Fixes #62

Description

Added the file extension .jsproj to the allowed extensions for XML files in order to modify such files using the config-file tag in the config.xml

Testing

  1. Add the following markup to the config.xml inside the <platform name="windows"> tag:
<config-file parent="/Project/PropertyGroup" target="CordovaApp.Windows10.jsproj" versions="10">
    <Test>Hello</Test>
</config-file>
  1. Run cordova build windows

Result without this change:
The build is aborted with the error message: malformed document. First element should be <plist>

Result with this change:
The build completes without errors and the <Test>Hello</Test> Tag is written to the CordovaApp.Windows10.jsproj file.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Jun 14, 2019
@janpio janpio changed the title (windows) Add .jsproj as file extension for XML files (#62) (windows) Add .jsproj as file extension for XML files Jun 14, 2019
@janpio janpio changed the title (windows) Add .jsproj as file extension for XML files (windows) Add .jsproj as file extension for XML files to ConfigFile Jun 14, 2019
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Sep 9, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erisu erisu merged commit 2704c91 into apache:master Sep 9, 2019
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

Modify *.jsproj files with "config-file" element
2 participants