revert: #24 CB-14108: fix incorrect count in config_munge

[erisu]

Platforms affected

all

Motivation and Context

Even though the PR had fixed the incorrect count in config_munge, which was an issues for plugin uninstall, it introduced issues for the plugin install. Specifically, if a user had installed a plugin that contains config-file and/or edit-config and in their project's config.xml the user also defined additional config-file and/or edit-config blocks, the config.xml would be used and all of the plugin's config-file and/or edit-config were not used, even if the contents of these blocks were not identical.

Description

This reverts commit ce3801a184d34cc4c3ea08aeecd159227c6ae9e9.

Reported in General/Tooling
fixes: apache/cordova#95
fixes: apache/cordova-cli#389

Reported in Android Platform
fixes: apache/cordova-android#704
fixes: apache/cordova-android#801
fixes: apache/cordova-android#809

Reported in iOS Platform
fixes: apache/cordova-ios#581
fixes: apache/cordova-ios#401

Other Possible Reports
This revert may also fix the following issues (similarity in report) but requires additional validation:

• Build command needs to be run twice to apply config.xml changes to appxmanifest cordova-windows#336
• Arrays in plist files can not be adjusted with edit-config cordova-ios#613 (This one has no mention of plugins so might not be related but worth checking)

Additional Notes

• The original issue that the breaking PR resolved will be reintroduced.
• A new ticket and separate PR should be created to attempt to resolve the original issue with out affect plugin install

Testing

• npm t
• Locally modified Cordova using reverted code.

Checklist

• I've run the tests to see all new and existing tests pass
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

[odai-alali]

Hi,

When will this changes be released? I re-installed cordova-cli and it's dependencies and still getting the same error with config files.

[Mapiac]

correct same issue as @odai-alali

Ant idea on release @erisu @dpogue ?

[brodybits]

Guys please ask this kind of question on the dev mailing list https://cordova.apache.org/contact/

We do not provide active support for closed issues or PRs.

And please keep in mind that Cordova is supported by a bunch of overworked volunteers since we lost backing from a couple major companies.

[dminkovsky]

I tried testing this locally to address jeduan/cordova-plugin-facebook4#828 by patching the deps of CLI 9.0.0 and iOS 5.0.1 to use 3.2.1 of this repo instead of 3.1.0 (i.e. dminkovsky/cordova-ios@aca209e). Unfortunately, no luck. Is there some other spot where this dependency needs to be adjusted? I used npm ls to ensure that cordova-lib that's used by cordova-cli was using 3.2.1, and likewise with cordova-ios.

[raphinesse]

@dminkovsky Strange, what you describe sounds correct to me. You could also try to install cordova@nightly to test this change. Please let us know if this fixes the issue.

[liuxiaoy]

I tried by patching the deps of CLI 9.0.0 and android 8.0.0 to use 3.2.1 of this repo instead of 3.1.0. Also no luck.