feat: support .gitignore files in generated app #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Nov 11, 2019
erisu
approved these changes
Nov 11, 2019
It is impossible to deploy `.gitignore` files via npm packages. Instead, Cordova templates should include `gitignore` files that we rename to `.gitignore`. This commit implements that renaming. For more details see apache/cordova-discuss#69. Closes apache#8 and cordova-app-hello-world#30
raphinesse
force-pushed
the
fix-gitignore
branch
from
7cd413a
to
e0d6e6b
Compare
erisu
approved these changes
Nov 15, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Nov 15, 2019
|
🎉
--
Sent from my mobile
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
It is impossible to deploy
.gitignorefiles via npm packages.Instead, Cordova templates should include
gitignorefiles that werename to
.gitignore. This PR implements that renaming.For more details see apache/cordova-discuss#69.
Closes #8, apache/cordova-app-hello-world#30 and apache/cordova-discuss#69.
This bumps the dependency on
cordova-app-hello-worldto a version that includes apache/cordova-app-hello-world#50.Description
Rename all
gitignorefiles in the generated app to.gitignore.Note: Originally we had discussed using the filename
_gitignorefor the source files but I eventually went with whatcreate-react-appis using in their templates.Testing
Added an automated test that passes.
Checklist