feat: ensure .gitignore file in generated app #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is impossible to deploy `.gitignore` files via npm packages. Instead, Cordova templates should include `gitignore` files that will be renamed to `.gitignore` by `cordova-create@>=3`. For more details see apache/cordova-discuss#69.
3 tasks
erisu
approved these changes
Nov 11, 2019
raphinesse
added a commit
to apache/cordova-create
that referenced
this pull request
Nov 15, 2019
It is impossible to deploy `.gitignore` files via npm packages. Instead, Cordova templates should include `gitignore` files that we rename to `.gitignore`. This PR implements that renaming. For more details see apache/cordova-discuss#69. This also bumps the dependency on `cordova-app-hello-world` to a version that includes apache/cordova-app-hello-world#50. Closes #8, apache/cordova-app-hello-world#30 and apache/cordova-discuss#69.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
It is impossible to deploy
.gitignorefiles via npm packages.Instead, Cordova templates should include
gitignorefiles that will berenamed to
.gitignorebycordova-create@>=3.For more details see apache/cordova-discuss#69.
Part of a solution for #30.
apache/cordova-create#53 is needed to do the actual renaming.
Description
Rename
.gitignoretogitignoreTesting
None