Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure app rel dependencies as abs paths #125

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 19, 2019

Motivation and Context

Build fails when the package.json contains a dependency that is from the local file system and is a relative path.

Description

This PR adds to the prepare step for the App's package.json to convert relative paths to absolute paths. If the converted path does not exist, it will be drop from being added to the App's package.json and a warning is displayed.

Testing

  • npm t
  • platform add, prepare, and build

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change

@erisu erisu added this to the 2.0.0 milestone Dec 19, 2019
@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #125   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         608    620   +12     
=====================================
+ Hits          608    620   +12
Impacted Files Coverage Δ
bin/templates/cordova/lib/prepare.js 100% <100%> (ø) ⬆️
bin/templates/cordova/lib/PackageJsonParser.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116825f...b3ebd73. Read the comment docs.

@erisu erisu force-pushed the v2-electron-relative-path-packages branch from f66f309 to b3ebd73 Compare December 19, 2019 22:02
@erisu erisu marked this pull request as ready for review December 22, 2019 22:23
Copy link
Contributor

@GedasGa GedasGa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out basic functionality, everything looks good!

@erisu erisu merged commit 8b51fc3 into apache:master Jan 21, 2020
@erisu erisu deleted the v2-electron-relative-path-packages branch January 21, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants