Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Bin Files #6

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Cleanup Bin Files #6

merged 1 commit into from
Dec 19, 2018

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 10, 2018 •
edited
Loading

Platforms affected

electron

What does this PR do?

  • Refactor's the binaries to be more consistent between each other.
  • This PR does not fix the issues within the existing workflow of the binaries usage. The workflow is currently in the requirements phase.

What testing has been done on this change?

$ npm t
$ npx cordova@latest create electronProject com.foo.bar
$ npx cordova@latest platform add ./cordova-electron

@erisu erisu merged commit 3af4318 into apache:master Dec 19, 2018
@erisu erisu deleted the bin-cleanup branch January 29, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erisu