Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cordova-common@^3.2.0 #70

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 15, 2019

Platforms affected

none

Motivation and Context

apache/cordova#121

Description

  • Bump dependency cordova-common to version ^3.2.0

Testing

  • npm t

  • CI

  • Run Test

    cordova create test1 com.foobar.test1 test1 && $_
    cordova platform add github:erisu/cordova-electron\#bump-cordova-common-3.2.0
    cordova run electron --nobuild
    

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 1.1.0 milestone Jun 15, 2019
@erisu erisu self-assigned this Jun 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #70   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         615    615           
=====================================
  Hits          615    615

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc33cc...f0f1f2c. Read the comment docs.

@@ -23,7 +23,7 @@
"test:coverage": "nyc jasmine --config=tests/spec/coverage.json"
},
"dependencies": {
"cordova-common": "^3.1.0",
"cordova-common": "^3.2.0",
"electron": "^4.0.1",
"electron-builder": "^20.38.4",
"fs-extra": "^7.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be bumped, since common now uses 8.0.x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a separate PR already in place for that.

#66

Once I merge this PR in, I will re-build the package-lock.json on that PR as well.

@erisu erisu merged commit 0c32148 into apache:master Jun 15, 2019
@erisu erisu deleted the bump-cordova-common-3.2.0 branch June 17, 2019 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants