GH-35 license header fixes #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2018 15:51
spec/support/dummy-local-plugin/plugin.xml (copied from cordova-plugin-device)
This was referenced Aug 6, 2018
brodycj
referenced
this pull request
Aug 6, 2018
.ratignore cover artifacts in spec/support/repo-name-neq-plugin-id.git
to ignore artifacts in spec/support/repo-name-neq-plugin-id.git
brodycj
force-pushed
the
gh-35-license-header-fixes
branch
from
ed14f04
to
ca9b66e
Compare
|
Approved by @raphinesse in ed14f04#commitcomment-29979429, merging. |
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 6, 2018
(cherry-pick from apacheGH-36)
brodycj
pushed a commit
to brodycj/cordova-fetch
that referenced
this pull request
Aug 14, 2018
(cherry-pick from apacheGH-36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes to resolve GH-35:
dos2unix spec/support/dummy-local-plugin/plugin.xmlspec/support/dummy-local-plugin/plugin.xml(copied fromcordova-plugin-device).ratignorecover artifacts inspec/support/repo-name-neq-plugin-id.gitThese changes are needed for
coho audit-license-headers -r fetchto pass ref: https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#testMerging: should be merged by rebase or merge commit