Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use PROVISIONING_PROFILE_SPECIFIER for manual codesigning #1405

Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 6, 2024

Platforms affected

ios

Motivation and Context

resolves #823
resolves #536

Description

cherry-picked changes from #823 and rebase with lastest main branch

Testing

n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 7.1.0 milestone Mar 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.24%. Comparing base (b400b70) to head (51abad8).

Files Patch % Lines
lib/build.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1405   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files          15       15           
  Lines        1788     1788           
=======================================
  Hits         1399     1399           
  Misses        389      389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu merged commit af6335e into apache:master Mar 6, 2024
9 checks passed
@erisu erisu deleted the fix/manual-signing-with-provisioning-profile-name branch March 6, 2024 06:24
ishiguro-m-wing added a commit to dejiren/cordova-ios that referenced this pull request Mar 29, 2024
This reverts commit 1974dbb.

Revert "feat: add privacy-manifest config support (apache#1406)"

This reverts commit c97845a.

Revert "ci(gh-action): add Apache RAT & package license checker workflow w/ license header additions (apache#1408)"

This reverts commit d316558.

Revert "fix: use PROVISIONING_PROFILE_SPECIFIER for manual codesigning (apache#1405)"

This reverts commit af6335e.

Revert "feat: add PrivacyInfo.xcprivacy for CordovaLib & app template (apache#1383)"

This reverts commit b400b70.

Revert "fix: WASM MIME type error by specifying it in Info.plist template (apache#1374)"

This reverts commit 902df96.

Revert "chore: update package & package-lock (apache#1404)"

This reverts commit 2091208.

Revert "chore: bump 7.1.0-dev for next minor release (apache#1403)"

This reverts commit 766adcf.

Revert "chore(deps-dev): bump @babel/traverse from 7.21.4 to 7.23.2 (apache#1382)"

This reverts commit 92017bb.

Revert "chore: Update Slack signup link in SUPPORT_QUESTION.md (apache#1380)"

This reverts commit be4c884.

Revert "chore: bump version 7.0.2-dev"

This reverts commit a1f3ace.
ishiguro-m-wing pushed a commit to dejiren/cordova-ios that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provisioning Profile not setup correctly with new build system
4 participants