CB-13164: Integrated cordova-plugin-console #330
Conversation
|
Not sure why AppVeyor is saying "AppVeyor was unable to build non-mergeable pull request", it looks mergeable to me. |
filmaj
force-pushed
the
integrate-console
branch
from
57e41a0
to
14b0490
Compare
|
I've rebased w/ master, let's see if that rejigs the wires. |
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 63.95% 63.95%
=======================================
Files 14 14
Lines 1673 1673
Branches 277 277
=======================================
Hits 1070 1070
Misses 603 603Continue to review full report at Codecov.
|
| @@ -65,6 +65,10 @@ | |||
| <feature name="LocalStorage"> | |||
| <param name="ios-package" value="CDVLocalStorage"/> | |||
| </feature> | |||
| <feature name="Console"> | |||
There was a problem hiding this comment.
You need to add this in defaults.xml as well. I tried adding the platform to a newly created CLI project, console.log failed because this wasn't in config.xml.
See b0c71bf
There was a problem hiding this comment.
really.... my locally generated project worked fine without that....
There was a problem hiding this comment.
oh is that a cordova-cli integration requirement or something? I was testing it without using cordova-cli, just by creating a project via ./bin/create, etc.
There was a problem hiding this comment.
Yes, see the linked commit description.
There was a problem hiding this comment.
makes mental note as good use case for integration test
…indow.console. - added native source files for CDVLogger - updated pbxproj file for CordovaLib to take the new files into account
filmaj
force-pushed
the
integrate-console
branch
from
14b0490
to
adabe28
Compare
What does this PR do?
Adds support for
window.consoleto be built in to generated cordova-ios projects. Essentially: sunsetting cordova-plugin-console and integrating its iOS bits into cordova-ios.NOTE: this PR requires the use of latest master of cordova-js.
What testing has been done on this change?
Just
npm testlocally on my Mac. Unsure if I should add any additional tests? @shazron leaning on you for guidance on that question.Checklist