CB-13523: Add flag for Xcode-managed provisioning #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 63.43% 63.41% -0.02%
==========================================
Files 14 14
Lines 1690 1692 +2
Branches 283 284 +1
==========================================
+ Hits 1072 1073 +1
- Misses 618 619 +1
Continue to review full report at Codecov.
|
dpogue
force-pushed
the
automatic-provisioning
branch
3 times, most recently
from
88f9fe7
to
9bd5306
Compare
This adds a `automaticProvisioning` option to the build config which passes flags to xcodebuild during the exporting step that allow it to automatically create and update provisioning profiles for automatic code signing.
dpogue
force-pushed
the
automatic-provisioning
branch
from
301f6d5
to
110b084
Compare
dpogue
changed the title
|
Nice. (Side note: Please make sure that the new option also gets documented - these definitely need documentation) |
surajpindoria
approved these changes
Nov 15, 2017
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS with Xcode 9
What does this PR do?
This adds a
automaticProvisioningoption to the build config which passes flags to xcodebuild during the exporting step that allow it to automatically create and update provisioning profiles for automatic code signing.I don't love that we're adding even more random stuff to the build config, but I suspect most people don't want this to be enabled by default.
What testing has been done on this change?
Added a case to existing spec tests.
Tested with a Cordova project at work and confirmed to be working.
Checklist