Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13523: Pass automaticProvisioning to build step #358

Merged
merged 1 commit into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@dpogue
Copy link
Member

commented Feb 26, 2018

Platforms affected

iOS

What does this PR do?

Passes -allowProvisioningUpdates to the build/archive step. We are already passing it to the export step (#347) but it's also worth having it here.

What testing has been done on this change?

Testing on Ayogo's Jenkins instance and was able to successfully make an iOS build without any manual steps to set up certificates or provisioning profiles.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@dpogue dpogue requested a review from shazron Feb 26, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Feb 26, 2018

Codecov Report

Merging #358 into master will increase coverage by 0.04%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   63.95%   63.99%   +0.04%     
==========================================
  Files          14       14              
  Lines        1695     1697       +2     
  Branches      285      286       +1     
==========================================
+ Hits         1084     1086       +2     
  Misses        611      611
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/build.js 37.2% <75%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a817b...44c02e3. Read the comment docs.

@shazron

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

This flag is an Xcode 9 feature, so we need to bump this as well: https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/check_reqs.js#L29

I'm surprised that we still have that at 7...

@dpogue

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2018

Note this isn't enabled by default, it requires specifying "automaticProvisioning": true in build.json config, or as a --automaticProvisioning flag to the command

@shazron shazron merged commit 28e7ac1 into apache:master Feb 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dpogue dpogue deleted the dpogue:automatic-provisioning branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.