Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13597: (ios) update podfile with ios version 9.0 #349

Merged
merged 1 commit into from
Nov 22, 2017
Merged

CB-13597: (ios) update podfile with ios version 9.0 #349

merged 1 commit into from
Nov 22, 2017

Conversation

apare
Copy link
Contributor

@apare apare commented Nov 21, 2017

Since the release Cordova iOS 4.4.0, only iOS 9 and greater supported
https://cordova.apache.org/announcements/2017/04/26/ios-release.html

Platforms affected

  • ios

What does this PR do?

  • Upgrade the podfile ios version

What testing has been done on this change?

  • install a pod dependency with only support ios 9 (Curbside 3.0.0.0)

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@apare apare changed the title CB-13597: (ios) Invalid ios version in podfile CB-13597: (ios) update podfile with ios version 9.0 Nov 21, 2017
@codecov-io
Copy link

codecov-io commented Nov 21, 2017

Codecov Report

Merging #349 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   63.45%   63.45%           
=======================================
  Files          14       14           
  Lines        1691     1691           
  Branches      284      284           
=======================================
  Hits         1073     1073           
  Misses        618      618
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/Podfile.js 77.41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bfb73...fa18cfd. Read the comment docs.

@apare
Copy link
Contributor Author

apare commented Nov 22, 2017

travis error Version '6.11' not found - try nvm ls-remote to browse available versions.

@janpio
Copy link
Member

janpio commented Nov 22, 2017

I restarted the build on Travis - maybe it works this time.

@janpio
Copy link
Member

janpio commented Nov 22, 2017

That worked @apare.

@surajpindoria
Copy link
Member

LGTM!

@surajpindoria surajpindoria merged commit 4f873f7 into apache:master Nov 22, 2017
@apare apare deleted the podfile-ios-9 branch November 22, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants