Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13382 dealloc the webViewEngine #359

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Conversation

surajpindoria
Copy link
Member

@surajpindoria surajpindoria commented Feb 27, 2018

Platforms affected

iOS

What does this PR do?

Adds an additional clean up step to dealloc

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   63.99%   63.99%           
=======================================
  Files          14       14           
  Lines        1697     1697           
  Branches      286      286           
=======================================
  Hits         1086     1086           
  Misses        611      611

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28e7ac1...9307034. Read the comment docs.

@shazron shazron merged commit e75c38f into apache:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants