Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-407: remove removing certificates functions in xcode post scripts #508

Merged

Conversation

@knight9999
Copy link
Contributor

commented Jan 30, 2019

Platforms affected

ios

What does this PR do?

To fix #407 with automatic provioning.
This PR fixs the issue that ios-deploy (cordova run --device) can not work with automatic provisoning.

This PR simply remove following lines

shell.rm('-rf', path.join(dstDir, '_CodeSignature'));
shell.rm('-rf', path.join(dstDir, 'PkgInfo'));
shell.rm('-rf', path.join(dstDir, 'embedded.mobileprovision'));

in cordova/lib/copy-www-build-step.js.

I am not sure why that codes are here.
But I image that the old version of the cordova use xcrun for the certification after building process. In such situation, the above codes are necessary.

However I found that these codes lead strange behavior with automatic provisioning in ios-deploy (in cordova run --device) as reported in #407 .

What testing has been done on this change?

I test as following on my local mac (mojave).

  1. cordova run --device with automatic provisioning using Xcode 10.1.
  2. cordova run --device with manual provioning using Xcode 10.1.
  3. cordova run --device with automatic provisioning using Xcode 9.4.1.
  4. cordova run --device with manual provioning using Xcode 9.4.1.

All they works well.

npx cordova@nightly 
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
@codecov-io

This comment has been minimized.

Copy link

commented Jan 30, 2019

Codecov Report

Merging #508 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          11       11           
  Lines        1822     1822           
=======================================
  Hits         1362     1362           
  Misses        460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ef0cd...366676a. Read the comment docs.

@dpogue

dpogue approved these changes Jan 30, 2019

Copy link
Member

left a comment

Just ran an export in Xcode 10 (in the Xcode app) with these changes and automatic provisioning and it worked! 🎉

@erisu

erisu approved these changes Jan 30, 2019

Copy link
Member

left a comment

LGTM

@jpike88

This comment has been minimized.

Copy link

commented Jan 30, 2019

Nice, how will I know as soon as the next release contains this?

@dpogue

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Note: This also resolves CB-14264

@erisu erisu merged commit a5e2fba into apache:master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janpio

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

@jpike88 You can follow releases of repositories on Github (leftmost button at the top, next to "Star" and "Fork"), there will also be a blog post at blog.cordova.io.

@Menardi Menardi deleted the cordova-develop:fix_GH-407_support_auto_provisioning branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.