Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default minDeploymentTarget to 10.0 in Podfile #635

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

jcesarmobile
Copy link
Member

We updated the templates and cordovaLib to use 10.0 as deployment target in 5.0, but was not changed here in the Podfile generation.

@jcesarmobile jcesarmobile changed the title Bump default minDeploymentTarget to 10.0 Bump default minDeploymentTarget to 10.0 in Podfile Jun 25, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch 👍

Copy link
Contributor

@knight9999 knight9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

@jcesarmobile jcesarmobile merged commit 6d618c4 into apache:master Jun 26, 2019
@jcesarmobile jcesarmobile deleted the bump-min-deployment branch June 26, 2019 15:24
@ramgrg
Copy link

ramgrg commented Jan 21, 2020

Does this restrict minimum iOS version compatibility of the app?

@jcesarmobile
Copy link
Member Author

yes and no

yes because it sets the default minimum to iOS 10
but no because the default in other files was already iOS 10, so this only add consistency with the min used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants