Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated stringByAddingPercentEscapesUsingEncoding usage #789

Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 14, 2020

Motivation, Context & Description

Replace deprecated stringByAddingPercentEscapesUsingEncoding method with stringByAddingPercentEncodingWithAllowedCharacters

https://developer.apple.com/documentation/foundation/nsstring/1415058-stringbyaddingpercentescapesusin

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone Feb 14, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit acadb1b into apache:master Feb 14, 2020
@erisu erisu deleted the fix/stringByAddingPercentEscapesUsingEncoding branch February 14, 2020 14:10
NiklasMerz pushed a commit to GEDYSIntraWare/cordova-ios that referenced this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants