CB-8320: We look for a build.gradle to make sure it's Android, this allows plugman to be used with non-standard Cordova projects. #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AndroidManifest, because it moved
| throw new CordovaError('The provided path "' + project + '" is not an Android project.'); | ||
| } | ||
|
|
||
| // Call the base class constructor | ||
| Parser.call(this, 'android', project); | ||
|
|
||
| this.path = project; | ||
|
|
||
| //If we have a gradle file but not a manifest, this is an Android Studio project | ||
| if(!fs.existsSync(path.join(project, "AndroidManifest.xml"))) { |
There was a problem hiding this comment.
@infil00p Apparently this fails the jslint step because of double quotes here, which is why the Travis and Appveyor builds failed. It wants all JS strings to use single quotes.
There was a problem hiding this comment.
This just reminds me of how much I hate lint and Javascript in general.
|
This PR is hilariously out of date, and this functionality was added elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.