Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-8320: We look for a build.gradle to make sure it's Android, this allows plugman to be used with non-standard Cordova projects. #469

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion cordova-lib/src/cordova/metadata/android_parser.js
Expand Up @@ -31,14 +31,20 @@ var fs = require('fs'),


function android_parser(project) {
if (!fs.existsSync(path.join(project, 'AndroidManifest.xml'))) {
if (!fs.existsSync(path.join(project, 'build.gradle'))) {
throw new CordovaError('The provided path "' + project + '" is not an Android project.');
}

// Call the base class constructor
Parser.call(this, 'android', project);

this.path = project;

//If we have a gradle file but not a manifest, this is an Android Studio project
if(!fs.existsSync(path.join(project, 'AndroidManifest.xml'))) {
this.path = path.join(project, 'app', 'src', 'main');
}

this.strings = path.join(this.path, 'res', 'values', 'strings.xml');
this.manifest = path.join(this.path, 'AndroidManifest.xml');
this.android_config = path.join(this.path, 'res', 'xml', 'config.xml');
Expand Down