CB-13057 : Remove cordova platform save command #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I delete:
|
audreyso
force-pushed
the
CB-13057-2
branch
2 times, most recently
from
fdbff5e
to
b62ad02
Compare
stevengill
reviewed
Dec 11, 2017
src/cordova/platform_metadata.js
Outdated
| module.exports.getPlatformVersions = getVersions; | ||
| module.exports.save = save; | ||
| module.exports.remove = remove; | ||
| // /** |
There was a problem hiding this comment.
Did you mean to comment out this whole file? Might as well just delete it if that is the case
There was a problem hiding this comment.
Looks like these functions were being used by the save command, hence the comment out
src/cordova/platform/save.js
Outdated
| var cordova_util = require('../util'); | ||
| var ConfigParser = require('cordova-common').ConfigParser; | ||
| var platformMetadata = require('../platform_metadata'); | ||
| // var semver = require('semver'); |
There was a problem hiding this comment.
Lets delete this whole file as it seems like it is all commented out
src/cordova/platform/remove.js
Outdated
| @@ -79,7 +79,7 @@ function remove (hooksRunner, projectRoot, targets, opts) { | |||
| // Remove targets from platforms.json. | |||
| targets.forEach(function (target) { | |||
| events.emit('verbose', 'Removing platform ' + target + ' from platforms.json file...'); | |||
| platformMetadata.remove(projectRoot, target); | |||
| // platformMetadata.remove(projectRoot, target); | |||
src/cordova/platform/remove.js
Outdated
| @@ -25,7 +25,7 @@ var events = require('cordova-common').events; | |||
| var npmUninstall = require('cordova-fetch').uninstall; | |||
| var cordova_util = require('../util'); | |||
| var config = require('../config'); | |||
| var platformMetadata = require('../platform_metadata'); | |||
| // var platformMetadata = require('../platform_metadata'); | |||
src/cordova/platform/index.js
Outdated
| case 'save': | ||
| events.emit('warn', 'This command has been deprecated and will be removed in the next major release of cordova.'); | ||
| return module.exports.save(hooksRunner, projectRoot, opts); | ||
| // case 'save': |
| @@ -142,8 +142,8 @@ describe('tests platform/spec restore with --save', function () { | |||
| var cwd = process.cwd(); | |||
| var pkgJsonPath = path.join(cwd, 'package.json'); | |||
| var pkgJson; | |||
| var platformsFolderPath = path.join(cwd, 'platforms/platforms.json'); | |||
| var platformsJson; | |||
| //var platformsFolderPath = path.join(cwd, 'platforms/platforms.json'); | |||
There was a problem hiding this comment.
delete all the stuff that you commented in this file
integration-tests/pkgJson.spec.js
Outdated
| @@ -621,15 +621,15 @@ describe('During add, if pkg.json has a platform/plugin spec, use that one.', fu | |||
| var iosVersion; | |||
| var cwd = process.cwd(); | |||
| var iosDirectory = path.join(cwd, 'platforms/ios/cordova/version'); | |||
| var platformsFolderPath = path.join(cwd, 'platforms/platforms.json'); | |||
| //var platformsFolderPath = path.join(cwd, 'platforms/platforms.json'); | |||
| @@ -24,7 +24,7 @@ var events = require('cordova-common').events; | |||
| var rewire = require('rewire'); | |||
| var platform_addHelper = rewire('../../../src/cordova/platform/addHelper'); | |||
| var platform_module = require('../../../src/cordova/platform'); | |||
| var platform_metadata = require('../../../src/cordova/platform_metadata'); | |||
| // var platform_metadata = require('../../../src/cordova/platform_metadata'); | |||
There was a problem hiding this comment.
delete this + other commented out code
spec/cordova/platform/index.spec.js
Outdated
| fail('did not expect fail handler to be invoked'); | ||
| }).done(done); | ||
| }); | ||
| // it('should direct `save` commands to the `save` method/module', function (done) { |
spec/cordova/platform/remove.spec.js
Outdated
| @@ -21,7 +21,7 @@ var Q = require('q'); | |||
| var events = require('cordova-common').events; | |||
| var rewire = require('rewire'); | |||
| var platform_remove = rewire('../../../src/cordova/platform/remove'); | |||
| var platform_metadata = require('../../../src/cordova/platform_metadata'); | |||
| // var platform_metadata = require('../../../src/cordova/platform_metadata'); | |||
There was a problem hiding this comment.
delete this + other commented out code comments
audreyso
force-pushed
the
CB-13057-2
branch
4 times, most recently
from
ad3dcfa
to
df6f0a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
Remove cordova platform save command
What testing has been done on this change?
Checklist