Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14116: improve tests using ios@4.5.4, adjusting timeout params and improve p… #615

Merged
merged 2 commits into from Jun 6, 2018

Conversation

knight9999
Copy link

@knight9999 knight9999 commented Jun 4, 2018

…lugin remove sequentially

Platforms affected

all platforms

What does this PR do?

  1. For Test#022 on pkgJson.spec.js, using ios@4.5.4

  2. Adjust timeout parameters in pkgJson.spec.js.

  3. Fixing errors in Test#006 on platform.spec.js.
    cordova plugin rm spawns multiple npm uninstall commands simultaneously by Q.all.
    However multiple npm commands simultaneously sometimes bring a following errors,

{ CordovaError: Error: npm: Command failed with exit code 254 Error output:
npm WARN checkPermissions Missing write access to /tmp/e2e-test/plugin_rm_test/hello/node_modules/cordova-android/node_modules/abbrev
npm WARN checkPermissions Missing write access to /tmp/e2e-test/plugin_rm_test/hello/node_modules/cordova-android/node_modules/android-versions

Then I update uninstall.js by using sequential promises instead of Q.all.

What testing has been done on this change?

on travis c.i. testing.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh, thanks for tracking down the source of those weird deletion failures!

I don't love that we're increasing the (already very long) timeouts, but such is life on a shared CI I suppose

@knight9999
Copy link
Author

In order to pass the appveyor tests, I update as follows,

  1. Use cordova-brower 5.0.3 instead of 5.0.0
  2. Increase Timeout parameters
  3. clean event listeners after each test.

@knight9999
Copy link
Author

knight9999 commented Jun 5, 2018

Thanks for the reply, @dpogue
Sorry, I have increased timeouts more in order to pass the appveyor.

@dpogue dpogue merged commit b42ccc6 into apache:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants